OSDN Git Service

media: imx: Don't initialize vars that won't be used
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 26 Feb 2018 13:33:41 +0000 (08:33 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 26 Feb 2018 13:38:57 +0000 (08:38 -0500)
commit52e17089d1850774d2ef583cdef2b060b84fca8c
treeb7491b7a8c8fe33e1b4e4a1d584bfc9b84affad6
parent225fe212a2d58c7113aa2781a3594ae8d9827ea9
media: imx: Don't initialize vars that won't be used

As reported by gcc:

  + drivers/staging/media/imx/imx-media-csi.c: warning: variable 'input_fi' set but not used [-Wunused-but-set-variable]:  => 671:33
  + drivers/staging/media/imx/imx-media-csi.c: warning: variable 'pinctrl' set but not used [-Wunused-but-set-variable]:  => 1742:18

input_fi is not used, so just remove it.

However, pinctrl should be used, as it devm_pinctrl_get_select_default()
is declared with attribute warn_unused_result. What's missing there
is an error handling code, in case it fails. Add it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/imx/imx-media-csi.c