OSDN Git Service

Fix clang-tidy warnings in bt.
authorChih-Hung Hsieh <chh@google.com>
Wed, 17 Aug 2016 21:12:51 +0000 (14:12 -0700)
committerAndre Eisenbach <eisenbach@google.com>
Thu, 18 Aug 2016 00:29:13 +0000 (00:29 +0000)
commit5dc0d15e7865104d13be75c06de4b9158ce7dff4
tree71078696d9d114c5a76e218c6be71492cb0e3a06
parent7225e499e81c266f4abba84e2c574cb12eaa2d21
Fix clang-tidy warnings in bt.

* Add explicit keyword to conversion constructors,
  or add NOLINT to implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters,
  or add NOLINT to keep same callback function signature.
Bug: 30407689
* Use const reference type for loop index variables to avoid unnecessary copy.
Bug: 30413223
* Use const reference type to avoid unnecessary copy.
Bug: 30413862
Test: build with WITH_TIDY=1

Change-Id: I8237d332f32d7be09ab72a8de82160fdb776dcd1
27 files changed:
service/client/main.cc
service/common/android/bluetooth/bluetooth_gatt_characteristic.h
service/common/android/bluetooth/bluetooth_gatt_descriptor.h
service/common/android/bluetooth/bluetooth_gatt_included_service.h
service/common/android/bluetooth/bluetooth_gatt_service.h
service/common/bluetooth/scan_result.cc
service/common/bluetooth/scan_result.h
service/gatt_server.cc
service/gatt_server_old.cc
service/hal/bluetooth_gatt_interface.cc
service/hal/bluetooth_gatt_interface.h
service/hal/fake_bluetooth_gatt_interface.cc
service/hal/fake_bluetooth_gatt_interface.h
service/ipc/binder/bluetooth_binder_server.cc
service/ipc/binder/bluetooth_low_energy_binder_server.cc
service/low_energy_client.cc
service/low_energy_client.h
service/test/low_energy_client_unittest.cc
vendor_libs/test_vendor_lib/include/dual_mode_controller.h
vendor_libs/test_vendor_lib/include/event_packet.h
vendor_libs/test_vendor_lib/include/hci_transport.h
vendor_libs/test_vendor_lib/include/test_channel_transport.h
vendor_libs/test_vendor_lib/src/async_manager.cc
vendor_libs/test_vendor_lib/src/dual_mode_controller.cc
vendor_libs/test_vendor_lib/src/event_packet.cc
vendor_libs/test_vendor_lib/src/hci_transport.cc
vendor_libs/test_vendor_lib/src/test_channel_transport.cc