OSDN Git Service

dmaengine: coh901318: Fix a double-lock bug
authorJia-Ju Bai <baijiaju1990@gmail.com>
Tue, 6 Nov 2018 03:33:48 +0000 (11:33 +0800)
committerVinod Koul <vkoul@kernel.org>
Sat, 24 Nov 2018 14:29:54 +0000 (19:59 +0530)
commit627469e4445b9b12e0229b3bdf8564d5ce384dd7
treef2342787ccec2ad0ead6a6995298295d5bb5c019
parent651022382c7f8da46cb4872a545ee1da6d097d2a
dmaengine: coh901318: Fix a double-lock bug

The function coh901318_alloc_chan_resources() calls spin_lock_irqsave()
before calling coh901318_config().
But coh901318_config() calls spin_lock_irqsave() again in its
definition, which may cause a double-lock bug.

Because coh901318_config() is only called by
coh901318_alloc_chan_resources(), the bug fix is to remove the
calls to spin-lock and -unlock functions in coh901318_config().

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/coh901318.c