OSDN Git Service

drm/i915: Only call tasklet_kill() on the first prepare_reset
authorChris Wilson <chris@chris-wilson.co.uk>
Wed, 7 Mar 2018 13:42:26 +0000 (13:42 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 9 Mar 2018 14:13:35 +0000 (14:13 +0000)
commit68ad361285a9cc73b259f59adbaafde196c15987
tree73259d10ada08928cf1bce3e5b8d2b8690815630
parent47650db02dd52267953df81438c93cf8a0eb0e5e
drm/i915: Only call tasklet_kill() on the first prepare_reset

tasklet_kill() will spin waiting for the current tasklet to be executed.
However, if tasklet_disable() has been called, then the tasklet is never
executed but permanently put back onto the runlist until
tasklet_enable() is called. Ergo, we cannot use tasklet_kill() inside a
disable/enable pair. This is the case when we call set-wedge from inside
i915_reset(), and another request was submitted to us concurrent to the
reset.

Fixes: 963ddd63c314 ("drm/i915: Suspend submission tasklets around wedging")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180307134226.25492-6-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_gem.c