OSDN Git Service

mm/kmemleak: prevent soft lockup in first object iteration loop of kmemleak_scan()
authorWaiman Long <longman@redhat.com>
Tue, 14 Jun 2022 22:03:59 +0000 (18:03 -0400)
committerakpm <akpm@linux-foundation.org>
Fri, 17 Jun 2022 02:48:32 +0000 (19:48 -0700)
commit6edda04ccc7cfb281d139e352dbd5dd933bd2751
treeb2636bc590cb869ec6ad0ff59daabf2693b8bdc6
parent64977918c2381aaadd544535708294213cc964f6
mm/kmemleak: prevent soft lockup in first object iteration loop of kmemleak_scan()

The first RCU-based object iteration loop has to modify the object count.
So we cannot skip taking the object lock.

One way to avoid soft lockup is to insert occasional cond_resched() call
into the loop.  This cannot be done while holding the RCU read lock which
is to protect objects from being freed.  However, taking a reference to
the object will prevent it from being freed.  We can then do a
cond_resched() call after every 64k objects safely.

Link: https://lkml.kernel.org/r/20220614220359.59282-4-longman@redhat.com
Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/kmemleak.c