OSDN Git Service

perf report: Don't shadow inlined symbol with different addr range
authorHe Kuang <hekuang@huawei.com>
Tue, 19 Feb 2019 13:05:31 +0000 (21:05 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 19 Feb 2019 15:30:12 +0000 (12:30 -0300)
commit7346195e8643482968f547483e0d823ec1982fab
tree7657521e13771c3897f764a562c41d8e529a3fce
parente19a01c1438e123d169fd09376a221d844797174
perf report: Don't shadow inlined symbol with different addr range

We can't assume inlined symbols with the same name are equal, because
their address range may be different. This will cause the symbols with
different addresses be shadowed when adding to the hist entry, and lead
to ERANGE error when checking the symbol address during sample parse,
the addr should be within the range of [sym.start, sym.end].

The error message is like: "0x36aea60 [0x8]: failed to process type: 68".

The second parameter of symbol__new() is the length of the fake symbol
for the inline frame, which is the subtraction of the end and start
address of base_sym.

Signed-off-by: He Kuang <hekuang@huawei.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Milian Wolff <milian.wolff@kdab.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: aa441895f7b4 ("perf report: Compare symbol name for inlined frames when sorting")
Link: http://lkml.kernel.org/r/20190219130531.15692-1-hekuang@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/sort.c
tools/perf/util/srcline.c