OSDN Git Service

mfd: twl6040: Fix child-node lookup
authorJohan Hovold <johan@kernel.org>
Sat, 11 Nov 2017 15:38:44 +0000 (16:38 +0100)
committerLee Jones <lee.jones@linaro.org>
Wed, 29 Nov 2017 16:29:36 +0000 (16:29 +0000)
commit85e9b13cbb130a3209f21bd7933933399c389ffe
tree697601b0a1b1d5da36e8d7f9a57f30e3ced70830
parent0a423772de2f3d7b00899987884f62f63ae00dcb
mfd: twl6040: Fix child-node lookup

Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.

To make things worse, the parent node was prematurely freed, while the
child node was leaked.

Note that the CONFIG_OF compile guard can be removed as
of_get_child_by_name() provides a !CONFIG_OF implementation which always
fails.

Cc: stable <stable@vger.kernel.org> # 3.5
Fixes: 37e13cecaa14 ("mfd: Add support for Device Tree to twl6040")
Fixes: ca2cad6ae38e ("mfd: Fix twl6040 build failure")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/twl6040.c