OSDN Git Service

crypto: af_alg - fix NULL pointer dereference in
authorEric Biggers <ebiggers@google.com>
Tue, 28 Nov 2017 08:46:24 +0000 (00:46 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 29 Nov 2017 02:39:14 +0000 (13:39 +1100)
commit887207ed9e5812ed9239b6d07185a2d35dda91db
treecadb413b15f8fd9699ad3f48638795a7bb9fb31e
parentb32a7dc8aef1882fbf983eb354837488cc9d54dc
crypto: af_alg - fix NULL pointer dereference in

 af_alg_free_areq_sgls()

If allocating the ->tsgl member of 'struct af_alg_async_req' failed,
during cleanup we dereferenced the NULL ->tsgl pointer in
af_alg_free_areq_sgls(), because ->tsgl_entries was nonzero.

Fix it by only freeing the ->tsgl list if it is non-NULL.

This affected both algif_skcipher and algif_aead.

Fixes: e870456d8e7c ("crypto: algif_skcipher - overhaul memory management")
Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management")
Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: <stable@vger.kernel.org> # v4.14+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/af_alg.c