OSDN Git Service

jffs2: free jffs2_sb_info through jffs2_kill_sb()
authorHou Tao <houtao1@huawei.com>
Sat, 6 Oct 2018 09:09:35 +0000 (17:09 +0800)
committerBoris Brezillon <boris.brezillon@bootlin.com>
Tue, 16 Oct 2018 08:34:28 +0000 (10:34 +0200)
commit92e2921f7eee63450a5f953f4b15dc6210219430
treee227bd50d9195d4826bd19e5c0df670933f3a5a3
parent299b43535d3895bcde93cc7310b95b92b4fd8129
jffs2: free jffs2_sb_info through jffs2_kill_sb()

When an invalid mount option is passed to jffs2, jffs2_parse_options()
will fail and jffs2_sb_info will be freed, but then jffs2_sb_info will
be used (use-after-free) and freeed (double-free) in jffs2_kill_sb().

Fix it by removing the buggy invocation of kfree() when getting invalid
mount options.

Fixes: 92abc475d8de ("jffs2: implement mount option parsing and compression overriding")
Cc: stable@kernel.org
Signed-off-by: Hou Tao <houtao1@huawei.com>
Reviewed-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
fs/jffs2/super.c