OSDN Git Service

nir/algebraic: Don't put quotes around floating point literals
authorIan Romanick <ian.d.romanick@intel.com>
Tue, 18 Dec 2018 21:28:22 +0000 (13:28 -0800)
committerIan Romanick <ian.d.romanick@intel.com>
Wed, 19 Dec 2018 07:28:31 +0000 (23:28 -0800)
commit96c4b135e34d0804e41bfbc28fc1b5050c49d71e
tree3c148acefbad1ae0826fe0adcaf2b3b8e90e0ac6
parent0f7ba5758bd8a3e12b8b33ab471336eaa7dd6fbc
nir/algebraic: Don't put quotes around floating point literals

The quotation marks around 1.0 cause it to be treated as a string
instead of a floating point value.  The generator then treats it as an
arbitrary variable replacement, so any iand involving a ('ineg', ('b2i',
a)) matches.

v2: Remove misleading comment about sized literals (suggested by
Timothy).  Add assertion that the name of a varible is entierly
alphabetic (suggested by Jason).

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Tested-by: Timothy Arceri <tarceri@itsqueeze.com> [v1]
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> [v1]
Fixes: 6bcd2af0863 ("nir/algebraic: Add some optimizations for D3D-style Booleans")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109075
src/compiler/nir/nir_algebraic.py
src/compiler/nir/nir_opt_algebraic.py