OSDN Git Service

USB: omap_udc: fix crashes on probe error and module removal
authorAaro Koskinen <aaro.koskinen@iki.fi>
Sat, 24 Nov 2018 22:17:05 +0000 (00:17 +0200)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 26 Nov 2018 10:37:51 +0000 (12:37 +0200)
commit99f700366fcea1aa2fa3c49c99f371670c3c62f8
tree93cb9de08385ac7139d3b1475d8aec97a47f428b
parent286afdde1640d8ea8916a0f05e811441fbbf4b9d
USB: omap_udc: fix crashes on probe error and module removal

We currently crash if usb_add_gadget_udc_release() fails, since the
udc->done is not initialized until in the remove function.
Furthermore, on module removal the udc data is accessed although
the release function is already triggered by usb_del_gadget_udc()
early in the function.

Fix by rewriting the release and remove functions, basically moving
all the cleanup into the release function, and doing the completion
only in the module removal case.

The patch fixes omap_udc module probe with a failing gadged, and also
allows the removal of omap_udc. Tested by running "modprobe omap_udc;
modprobe -r omap_udc" in a loop.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/udc/omap_udc.c