OSDN Git Service

perf pmu: Fix pmu events parsing rule
authorJiri Olsa <jolsa@kernel.org>
Mon, 23 Apr 2018 09:08:18 +0000 (11:08 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 23 Apr 2018 14:17:27 +0000 (11:17 -0300)
commit9a4a931ce847f4aaa12edf11b2e050e18bf45910
treed151e99dead05287e46867b97f10b32c5d0303ef
parent129193bb0c43d42f1c397c175346e3e0dba5a578
perf pmu: Fix pmu events parsing rule

Currently all the event parsing fails end up in the event_pmu rule, and
display misleading help like:

  $ perf stat -e inst kill
  event syntax error: 'inst'
                       \___ Cannot find PMU `inst'. Missing kernel support?
  ...

The reason is that the event_pmu is too strong and match also single
string. Changing it to force the '/' separators to be part of the rule,
and getting the proper error now:

  $ perf stat -e inst kill
  event syntax error: 'inst'
                       \___ parser error
  Run 'perf list' for a list of valid events
  ...

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Reported-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180423090823.32309-5-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/parse-events.y