OSDN Git Service

scsi: target: compare full CHAP_A Algorithm strings
authorDavid Disseldorp <ddiss@suse.de>
Thu, 12 Sep 2019 09:55:45 +0000 (11:55 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 23 Oct 2019 02:14:24 +0000 (22:14 -0400)
commit9cef2a7955f2754257a7cddedec16edae7b587d0
tree19c477a6e51f9e7cf3bf55ee338b2231c203ab05
parentc695793b52216ad6a11ce952fc8d29f3a9d0c7cd
scsi: target: compare full CHAP_A Algorithm strings

RFC 2307 states:

  For CHAP [RFC1994], in the first step, the initiator MUST send:

      CHAP_A=<A1,A2...>

   Where A1,A2... are proposed algorithms, in order of preference.
...
   For the Algorithm, as stated in [RFC1994], one value is required to
   be implemented:

       5     (CHAP with MD5)

LIO currently checks for this value by only comparing a single byte in
the tokenized Algorithm string, which means that any value starting with
a '5' (e.g. "55") is interpreted as "CHAP with MD5". Fix this by
comparing the entire tokenized string.

Reviewed-by: Lee Duncan <lduncan@suse.com>
Reviewed-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Link: https://lore.kernel.org/r/20190912095547.22427-2-ddiss@suse.de
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/iscsi/iscsi_target_auth.c