OSDN Git Service

hw/block: Fix the return type
authorMao Zhongyi <maozy.fnst@cn.fujitsu.com>
Wed, 22 Nov 2017 03:08:44 +0000 (11:08 +0800)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 19 Dec 2017 09:25:28 +0000 (09:25 +0000)
commit9d3b155186c2788570f4802700d030c84e0f0746
tree9a2e7a1812296503aa72fb4df7683ae3759bca97
parente01d6a415bec6fb93a7413929fb1438a22d28419
hw/block: Fix the return type

When the function no success value to transmit, it usually make the
function return void. It has turned out not to be a success, because
it means that the extra local_err variable and error_propagate() will
be needed. It leads to cumbersome code, therefore, transmit success/
failure in the return value is worth.

So fix the return type of blkconf_apply_backend_options(),
blkconf_geometry() and virtio_blk_data_plane_create() to avoid it.

Cc: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: ac0edc1fc70c4457e5cec94405eb7d1f89f9c2c1.1511317952.git.maozy.fnst@cn.fujitsu.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/block/block.c
hw/block/dataplane/virtio-blk.c
hw/block/dataplane/virtio-blk.h
include/hw/block/block.h