OSDN Git Service

drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse()
authorDhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Thu, 27 Sep 2018 20:57:30 +0000 (13:57 -0700)
committerDhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Fri, 28 Sep 2018 02:32:26 +0000 (19:32 -0700)
commit9ebd8202393dde9d3678c9ec162c1aa63ba17eac
tree3032b0a41339a3724783b15eac8089a7df9c7f9b
parenta2bf92e8cc16f6bf33bc8053c776630c79ad0325
drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse()

Comment claims link needs to be retrained because the connected sink raised
a long pulse to indicate link loss. If the sink did so,
intel_dp_hotplug() would have handled link retraining. Looking at the
logs in Bugzilla referenced in commit '3cf71bc9904d ("drm/i915: Re-apply
Perform link quality check, unconditionally during long pulse"")', the
issue is that the sink does not trigger an interrupt. What we want is
->detect() from user space to check link status and retrain. Ville's
review for the original patch also indicates the same root cause. So,
rewrite the comment.

v2: Patch split and rewrote comment.

Cc: Lyude Paul <lyude@redhat.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jan-Marek Glogowski <glogow@fbihome.de>
References: 3cf71bc9904d ("drm/i915: Re-apply "Perform link quality check, unconditionally during long pulse"")
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180927205735.16651-1-dhinakaran.pandiyan@intel.com
drivers/gpu/drm/i915/intel_dp.c