OSDN Git Service

PM / runtime: Drop usage count for suppliers at device link removal
authorUlf Hansson <ulf.hansson@linaro.org>
Thu, 24 May 2018 08:33:36 +0000 (10:33 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sun, 27 May 2018 10:18:55 +0000 (12:18 +0200)
commita0504aecba76baa1cddbc23512eb8be14df74cef
treee77b3dd0c67e21445e6cf94ee6cd2899451772cf
parent1e8378619841ef1d621b130bbd3fc3b7e6739b50
PM / runtime: Drop usage count for suppliers at device link removal

In the case consumer device is runtime resumed, while the link to the
supplier is removed, the earlier call to pm_runtime_get_sync() made from
rpm_get_suppliers() does not get properly balanced with a corresponding
call to pm_runtime_put(). This leads to that suppliers remains to be
runtime resumed forever, while they don't need to.

Let's fix the behaviour by calling rpm_put_suppliers() when dropping a
device link. Not that, since rpm_put_suppliers() checks the
link->rpm_active flag, we can correctly avoid to call pm_runtime_put() in
cases when we shouldn't.

Reported-by: Todor Tomov <todor.tomov@linaro.org>
Fixes: 21d5c57b3726 (PM / runtime: Use device links)
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/runtime.c