OSDN Git Service

powerpc/pseries/hotplug-cpu: Remove double free in error path
authorNathan Lynch <nathanl@linux.ibm.com>
Thu, 19 Sep 2019 23:16:33 +0000 (18:16 -0500)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 30 Jul 2020 12:53:49 +0000 (22:53 +1000)
commita0ff72f9f5a780341e7ff5e9ba50a0dad5fa1980
treeb5adb262650b6d0866fe75ab730f9b4061ffdfa6
parent5d8b1f9dea17b4bf5e5f088f39eeab32c7e487be
powerpc/pseries/hotplug-cpu: Remove double free in error path

In the unlikely event that the device tree lacks a /cpus node,
find_dlpar_cpus_to_add() oddly frees the cpu_drcs buffer it has been
passed before returning an error. Its only caller also frees the
buffer on error.

Remove the less conventional kfree() of a caller-supplied buffer from
find_dlpar_cpus_to_add().

Fixes: 90edf184b9b7 ("powerpc/pseries: Add CPU dlpar add functionality")
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20190919231633.1344-1-nathanl@linux.ibm.com
arch/powerpc/platforms/pseries/hotplug-cpu.c