OSDN Git Service

nfsd: Fix svc_xprt refcnt leak when setup callback client failed
authorXiyu Yang <xiyuyang19@fudan.edu.cn>
Mon, 25 May 2020 14:15:41 +0000 (22:15 +0800)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 28 May 2020 22:15:00 +0000 (18:15 -0400)
commita4abc6b12eb1f7a533c2e7484cfa555454ff0977
tree42dba531e3f504011b4e57b4e23cbf20c7a7a24c
parent24c5efe41c29ee3e55bcf5a1c9f61ca8709622e8
nfsd: Fix svc_xprt refcnt leak when setup callback client failed

nfsd4_process_cb_update() invokes svc_xprt_get(), which increases the
refcount of the "c->cn_xprt".

The reference counting issue happens in one exception handling path of
nfsd4_process_cb_update(). When setup callback client failed, the
function forgets to decrease the refcnt increased by svc_xprt_get(),
causing a refcnt leak.

Fix this issue by calling svc_xprt_put() when setup callback client
failed.

Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4callback.c