OSDN Git Service

PCI: cadence: Correct probe behaviour when failing to get PHY
authorAlan Douglas <adouglas@cadence.com>
Fri, 28 Sep 2018 10:51:18 +0000 (11:51 +0100)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Fri, 28 Sep 2018 15:08:56 +0000 (16:08 +0100)
commitaa77e55d48124d0d78456eabf872fffb5decdbe1
tree88a63265c0c233e7318aff387f75a68c389ec733
parent7876320f88802b22d4e2daf7eb027dd14175a0f8
PCI: cadence: Correct probe behaviour when failing to get PHY

Test the correct value to see whether the PHY get failed.

Use devm_phy_get() instead of devm_phy_optional_get(), since it is
only called if phy name is given in devicetree and so should exist.
If failure when getting or linking PHY, put any PHYs which were
already got and unlink them.

Fixes: dfb80534692ddc5b ("PCI: cadence: Add generic PHY support to host and EP drivers")
Reported-by: Colin King <colin.king@canonical.com>
Signed-off-by: Alan Douglas <adouglas@cadence.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
drivers/pci/controller/pcie-cadence.c