OSDN Git Service

drm/meson: Fix potential NULL dereference in meson_drv_bind_master()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 20 Mar 2018 14:20:30 +0000 (14:20 +0000)
committerNeil Armstrong <narmstrong@baylibre.com>
Tue, 20 Mar 2018 16:15:40 +0000 (17:15 +0100)
commitacaa3f13b8dd77da3c6c0fe18cb1159eef7ea286
tree0062ecc7d7aabc995ae2c976bd0afea09c50e279
parentddc389f5a4abb4c0c91202cd6dc09a28b9e2d82c
drm/meson: Fix potential NULL dereference in meson_drv_bind_master()

platform_get_resource_byname() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource_byname(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1521555630-29284-1-git-send-email-weiyongjun1@huawei.com
drivers/gpu/drm/meson/meson_drv.c