OSDN Git Service

Optimizing: LoadString may not have any side effects.
authorVladimir Marko <vmarko@google.com>
Tue, 5 Apr 2016 10:18:49 +0000 (11:18 +0100)
committerVladimir Marko <vmarko@google.com>
Tue, 5 Apr 2016 11:27:58 +0000 (12:27 +0100)
commitace7a000a433ce4ecf94f30adea39c01a76fa936
tree9d41d8974c1feda1af134a536eee8064028d670f
parent75563e34a4e64a8e805e6810b13e07f1cafec137
Optimizing: LoadString may not have any side effects.

LoadString does not have any side effects if the string is
known to be in the dex cache or it's a boot image string
referenced directly, as specified by the string load kind.
We need to clear the side effects for these cases to avoid
a DCHECK() failure when such LoadString instruction ends up
between a ClinitCheck and an instruction to which we want to
merge that ClinitCheck. This may happen as a consequence of
inlining, LICM and DCE as shown by a regression test.

Bug: 27929914
Change-Id: I7b3bddf7d8c79ce1828a4a751f1270cf2e3d61f0
compiler/optimizing/nodes.cc
compiler/optimizing/nodes.h
test/594-load-string-regression/expected.txt [new file with mode: 0644]
test/594-load-string-regression/info.txt [new file with mode: 0644]
test/594-load-string-regression/src/Main.java [new file with mode: 0644]