OSDN Git Service

clk: sunxi: Fix operator precedence in sunxi_divs_clk_setup
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 22 Oct 2019 16:50:54 +0000 (09:50 -0700)
committerMaxime Ripard <mripard@kernel.org>
Tue, 29 Oct 2019 07:42:31 +0000 (08:42 +0100)
commitafdc74ed2d57e86c10b1d6831339770a802bab9a
tree22ac3c1d26e94bad993f41229531926f81048daf
parent54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c
clk: sunxi: Fix operator precedence in sunxi_divs_clk_setup

r375326 in Clang exposes an issue with operator precedence in
sunxi_div_clk_setup:

drivers/clk/sunxi/clk-sunxi.c:1083:30: warning: operator '?:' has lower
precedence than '|'; '|' will be evaluated first
[-Wbitwise-conditional-parentheses]
                                                 data->div[i].critical ?
                                                 ~~~~~~~~~~~~~~~~~~~~~ ^
drivers/clk/sunxi/clk-sunxi.c:1083:30: note: place parentheses around
the '|' expression to silence this warning
                                                 data->div[i].critical ?
                                                                       ^
                                                                      )
drivers/clk/sunxi/clk-sunxi.c:1083:30: note: place parentheses around
the '?:' expression to evaluate it first
                                                 data->div[i].critical ?
                                                                       ^
                                                 (
1 warning generated.

It appears that the intention was for ?: to be evaluated first so that
CLK_IS_CRITICAL could be added to clkflags if the critical boolean was
set; right now, | is being evaluated first. Add parentheses around the
?: block to have it be evaluated first.

Fixes: 9919d44ff297 ("clk: sunxi: Use CLK_IS_CRITICAL flag for critical clks")
Link: https://github.com/ClangBuiltLinux/linux/issues/745
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/clk/sunxi/clk-sunxi.c