OSDN Git Service

cdc-wdm: Clear read pipeline in case of error
authorRobert Foss <robert.foss@collabora.com>
Tue, 9 Aug 2016 14:54:52 +0000 (10:54 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Aug 2016 08:15:30 +0000 (10:15 +0200)
commitc1da59dad0ebd3f9bd238f3fff82b1f7ffda7829
tree5620e6f5048a292a608aca7afa96c3ee742523be
parent0775a9cbc694e8c7276688be3bbd2f386167ab54
cdc-wdm: Clear read pipeline in case of error

Implemented queued response handling. This queue is processed every time the
WDM_READ flag is cleared.

In case of a read error, userspace may not actually read the data, since the
driver returns an error through wdm_poll. After this, the underlying device may
attempt to send us more data, but the queue is not processed. While userspace is
also blocked, because the read error is never cleared.

After this patch, we proactively process the queue on a read error. If there was
an outstanding response to handle, that will clear the error (or go through the
same logic again, if another read error occurs). If there was no outstanding
response, this will bring the queue size back to 0, unblocking a future response
from the underlying device.

Signed-off-by: Robert Foss <robert.foss@collabora.com>
Tested-by: Robert Foss <robert.foss@collabora.com>
Acked-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/cdc-wdm.c