OSDN Git Service

Revert "drm/i915/icl: WaEnableFloatBlendOptimization"
authorMika Kuoppala <mika.kuoppala@linux.intel.com>
Mon, 30 Jul 2018 12:06:36 +0000 (15:06 +0300)
committerMika Kuoppala <mika.kuoppala@linux.intel.com>
Wed, 1 Aug 2018 14:17:27 +0000 (17:17 +0300)
commitc358514ba8da9e235876db1628cedd19a35803c6
treeff1c9278719eaefbc99eb30ad0275d5ca0fb0eb3
parent21eb1850fa0bd0a9b729bf3708da78888433027f
Revert "drm/i915/icl: WaEnableFloatBlendOptimization"

The register for 0xe420 is unable to hold any value, including
this bit. The documentation is also mixed between having a
register bit for toggle and having a state command setup
for it. Apparently the register toggle is deprecated.

Remove the register toggle as evidence shows it's futile.

The thing remaining is an apology and humble request for
Mesa folks to resurrect their state setup for this as they
were on right track from start.

This reverts commit 0bf059f3532bb39c52d917142206a8554fc2f1c5.

Fixes: 0bf059f3532b ("drm/i915/icl: WaEnableFloatBlendOptimization")
References: HSDES#1406393558
Cc: Oscar Mateo <oscar.mateo@intel.com>
Cc: Anuj Phogat <anuj.phogat@gmail.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20180730120636.26958-1-mika.kuoppala@linux.intel.com
drivers/gpu/drm/i915/i915_reg.h
drivers/gpu/drm/i915/intel_workarounds.c