OSDN Git Service

scsi: ibmvfc: fix misdefined reserved field in ibmvfc_fcp_rsp_info
authorTyrel Datwyler <tyreld@linux.vnet.ibm.com>
Wed, 24 Jan 2018 02:11:32 +0000 (20:11 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 31 Jan 2018 02:16:27 +0000 (21:16 -0500)
commitc39813652700f3df552b6557530f1e5f782dbe2f
treea36958a83032ba614968f62fe4080be4aeccf541
parent2ce87cc5b269510de9ca1185ca8a6e10ec78c069
scsi: ibmvfc: fix misdefined reserved field in ibmvfc_fcp_rsp_info

The fcp_rsp_info structure as defined in the FC spec has an initial 3
bytes reserved field. The ibmvfc driver mistakenly defined this field as
4 bytes resulting in the rsp_code field being defined in what should be
the start of the second reserved field and thus always being reported as
zero by the driver.

Ideally, we should wire ibmvfc up with libfc for the sake of code
deduplication, and ease of maintaining standardized structures in a
single place. However, for now simply fixup the definition in ibmvfc for
backporting to distros on older kernels. Wiring up with libfc will be
done in a followup patch.

Cc: <stable@vger.kernel.org>
Reported-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ibmvscsi/ibmvfc.h