OSDN Git Service

rpmsg: glink: Don't send pending rx_done during remove
authorBjorn Andersson <bjorn.andersson@linaro.org>
Fri, 4 Oct 2019 22:27:01 +0000 (15:27 -0700)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 17 Oct 2019 13:23:10 +0000 (06:23 -0700)
commitc3dadc19b7564c732598b30d637c6f275c3b77b6
treeb6f01b54f11cea981a8a7123213b565b07f07643
parentf7e714988edaffe6ac578318e99501149b067ba0
rpmsg: glink: Don't send pending rx_done during remove

Attempting to transmit rx_done messages after the GLINK instance is
being torn down will cause use after free and memory leaks. So cancel
the intent_work and free up the pending intents.

With this there are no concurrent accessors of the channel left during
qcom_glink_native_remove() and there is therefor no need to hold the
spinlock during this operation - which would prohibit the use of
cancel_work_sync() in the release function. So remove this.

Fixes: 1d2ea36eead9 ("rpmsg: glink: Add rx done command")
Cc: stable@vger.kernel.org
Acked-by: Chris Lew <clew@codeaurora.org>
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/rpmsg/qcom_glink_native.c