OSDN Git Service

mtd: rawnand: denali: fix a race condition when DMA is kicked
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Thu, 13 Sep 2018 05:58:49 +0000 (14:58 +0900)
committerBoris Brezillon <boris.brezillon@bootlin.com>
Sat, 15 Sep 2018 08:05:26 +0000 (10:05 +0200)
commitcf51e4b9c34407bf0c3d9b582b7837e047e1df47
tree67c7174f879318cb5fd625f8f0eee0a61e85ee34
parent21a268069203cc72d1b2990bc68386516fabc274
mtd: rawnand: denali: fix a race condition when DMA is kicked

I thought the read-back of the DMA_ENABLE register was unnecessary
(at least it is working on my boards), then deleted it in commit
586a2c52909d ("mtd: nand: denali: squash denali_enable_dma() helper
into caller").  Sorry, I was wrong - it caused a timing issue on
Cyclone5 SoCFPGAs.

Revive the register read-back, commenting why this is necessary.

Fixes: 586a2c52909d ("mtd: nand: denali: squash denali_enable_dma() helper into caller")
Cc: <stable@vger.kernel.org>
Reported-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
drivers/mtd/nand/raw/denali.c