OSDN Git Service

drm/mediatek: don't open-code drm_gem_fb_create
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 15 Nov 2019 09:21:15 +0000 (10:21 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 22 Nov 2019 17:09:18 +0000 (18:09 +0100)
commitd268f42e68561594d304f9255f809b3ee50b1cdc
tree93b8de18d4a92d2b319592e17a9cc493ff1d20d4
parent92ec07677107974c31b32030a4f897398e452ca9
drm/mediatek: don't open-code drm_gem_fb_create

Aside: There's a few other fb_create implementations which
simply check for valid buffer format (or an approximation thereof),
and then call drm_gem_fb_create. For atomic drivers at least we could
walk all planes and make sure the format/modifier combo is valid,
and remove even more code.

For non-atomic drivers that's not possible, since the format list for
the primary buffer might be garbage (and most likely it is).

Also delete mtk_drm_fb.[hc] since it would now only contain one
function.

Acked-by: CK Hu <ck.hu@mediatek.com>
Cc: CK Hu <ck.hu@mediatek.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20191115092120.4445-4-daniel.vetter@ffwll.ch
drivers/gpu/drm/mediatek/mtk_drm_drv.c
drivers/gpu/drm/mediatek/mtk_drm_fb.c [deleted file]
drivers/gpu/drm/mediatek/mtk_drm_fb.h [deleted file]
drivers/gpu/drm/mediatek/mtk_drm_plane.c