OSDN Git Service

platform/x86: thinkpad_acpi: Fix max_brightness of thinklight
authorHans de Goede <hdegoede@redhat.com>
Mon, 7 Nov 2022 12:43:22 +0000 (13:43 +0100)
committerHans de Goede <hdegoede@redhat.com>
Wed, 16 Nov 2022 07:48:19 +0000 (08:48 +0100)
commitdb5e2a4ca0a7a5fe54f410590292ea2e91de6798
tree8e724abdf313446a4b5e085caed499a1889768a1
parente57d58ee1868b1ad3e8040335a2941506feb52e4
platform/x86: thinkpad_acpi: Fix max_brightness of thinklight

Thinklight has only two values, on/off so it's reasonable for
max_brightness to be 0 and 1 as if you write anything between 0 and 255
it will be 255 anyway so there's no point for it to be 255.

This may look like it is a userspace API change, but writes with
a value larget then the new max_brightness will still be accepted,
these will be silently clamped to the new max_brightness by
led_set_brightness_nosleep(). So no userspace API problems are
expected.

Reported-by: MichaƂ Szczepaniak <m.szczepaniak.000@gmail.com>
Link: https://lore.kernel.org/platform-driver-x86/55400326-e64f-5444-94e5-22b8214d00b6@gmail.com/
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/thinkpad_acpi.c