OSDN Git Service

mmc: wbsd: fix return value check of mmc_add_host()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 9 Nov 2022 13:32:37 +0000 (21:32 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 7 Dec 2022 12:22:35 +0000 (13:22 +0100)
commitdc5b9b50fc9d1334407e316e6e29a5097ef833bd
tree64c0024f3ad6296de7975141cdd75b37c01a5e16
parente4e46fb61e3bb4628170810d3f2b996b709b90d9
mmc: wbsd: fix return value check of mmc_add_host()

mmc_add_host() may return error, if we ignore its return value,
it will lead two issues:
1. The memory that allocated in mmc_alloc_host() is leaked.
2. In the remove() path, mmc_remove_host() will be called to
   delete device, but it's not added yet, it will lead a kernel
   crash because of null-ptr-deref in device_del().

So fix this by checking the return value and goto error path which
will call mmc_free_host(), besides, other resources also need be
released.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221109133237.3273558-1-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/wbsd.c