OSDN Git Service

scsi: sd: Clean up sd_setup_read_write_cmnd()
authorMartin K. Petersen <martin.petersen@oracle.com>
Wed, 16 Jan 2019 00:50:01 +0000 (16:50 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 23 Jan 2019 02:18:27 +0000 (21:18 -0500)
commite249e42d277ef4993230b193880fbe9a307084eb
tree7a32748274369927913a3693c11da8f77a01cfc6
parent78a02f49d0eb978b5eb85ffdf5f11582ac83c754
scsi: sd: Clean up sd_setup_read_write_cmnd()

Rework sd_setup_read_write_cmnd() so it becomes more readable. Put all the
sanity checking at the head of the function and sanitize the logged error
messages. Move the legacy SCSI logging calls to the end of the functions
and reduce conditional nesting.

Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ bvanassche: ported this patch from kernel v4.11 to kernel v5.0 ]
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c