OSDN Git Service

tipc: fix the skb_unshare() in tipc_buf_append()
authorCong Wang <xiyou.wangcong@gmail.com>
Thu, 8 Oct 2020 04:12:50 +0000 (21:12 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 10 Oct 2020 01:22:56 +0000 (18:22 -0700)
commited42989eab57d619667d7e87dfbd8fe207db54fe
treefdae4819eae47284a2137e45636912a02fa28874
parent923527dcb4d164925a2fed0b53c6a1625a60a472
tipc: fix the skb_unshare() in tipc_buf_append()

skb_unshare() drops a reference count on the old skb unconditionally,
so in the failure case, we end up freeing the skb twice here.
And because the skb is allocated in fclone and cloned by caller
tipc_msg_reassemble(), the consequence is actually freeing the
original skb too, thus triggered the UAF by syzbot.

Fix this by replacing this skb_unshare() with skb_cloned()+skb_copy().

Fixes: ff48b6222e65 ("tipc: use skb_unshare() instead in tipc_buf_append()")
Reported-and-tested-by: syzbot+e96a7ba46281824cc46a@syzkaller.appspotmail.com
Cc: Jon Maloy <jmaloy@redhat.com>
Cc: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tipc/msg.c