OSDN Git Service

crypto: gcm - wait for crypto op not signal safe
authorGilad Ben-Yossef <gilad@benyossef.com>
Thu, 18 May 2017 13:29:25 +0000 (16:29 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 23 May 2017 04:45:11 +0000 (12:45 +0800)
commitf3ad587070d6bd961ab942b3fd7a85d00dfc934b
tree8a9cf50696cd9177932b41fa1dc274ae63b6dbf2
parenta5dfefb1c3f3db81662556393fd9283511e08430
crypto: gcm - wait for crypto op not signal safe

crypto_gcm_setkey() was using wait_for_completion_interruptible() to
wait for completion of async crypto op but if a signal occurs it
may return before DMA ops of HW crypto provider finish, thus
corrupting the data buffer that is kfree'ed in this case.

Resolve this by using wait_for_completion() instead.

Reported-by: Eric Biggers <ebiggers3@gmail.com>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
CC: stable@vger.kernel.org
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/gcm.c