OSDN Git Service

tracing: Add 'last error' error facility for hist triggers
authorTom Zanussi <tom.zanussi@linux.intel.com>
Tue, 16 Jan 2018 02:52:05 +0000 (20:52 -0600)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Sat, 10 Mar 2018 21:06:02 +0000 (16:06 -0500)
commitf404da6e1d46ced7d3b53377f1e140c486ea7350
tree32a170bc8d274e206dc090548a599c072bc591bc
parent7e8b88a30b085d4205b6afcc5e577604978b1268
tracing: Add 'last error' error facility for hist triggers

With the addition of variables and actions, it's become necessary to
provide more detailed error information to users about syntax errors.

Add a 'last error' facility accessible via the erroring event's 'hist'
file.  Reading the hist file after an error will display more detailed
information about what went wrong, if information is available.  This
extended error information will be available until the next hist
trigger command for that event.

  # echo xxx > /sys/kernel/debug/tracing/events/sched/sched_wakeup/trigger
  echo: write error: Invalid argument

  # cat /sys/kernel/debug/tracing/events/sched/sched_wakeup/hist

  ERROR: Couldn't yyy: zzz
  Last command: xxx

Also add specific error messages for variable and action errors.

Link: http://lkml.kernel.org/r/64e9c422fc8aeafcc2f7a3b4328c0cffe7969129.1516069914.git.tom.zanussi@linux.intel.com
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Documentation/trace/histogram.txt
kernel/trace/trace_events_hist.c