OSDN Git Service

NFSv4: Retry LOCK on OLD_STATEID during delegation return
authorBenjamin Coddington <bcodding@redhat.com>
Wed, 19 Oct 2022 16:09:18 +0000 (12:09 -0400)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Thu, 27 Oct 2022 19:52:10 +0000 (15:52 -0400)
commitf5ea16137a3fa2858620dc9084466491c128535f
tree370281a73440a4f3c50daa885abf2b4a397a8f00
parentcbdeaee94a415800c65a8c3fa04d9664a8b8fb3a
NFSv4: Retry LOCK on OLD_STATEID during delegation return

There's a small window where a LOCK sent during a delegation return can
race with another OPEN on client, but the open stateid has not yet been
updated.  In this case, the client doesn't handle the OLD_STATEID error
from the server and will lose this lock, emitting:
"NFS: nfs4_handle_delegation_recall_error: unhandled error -10024".

Fix this by sending the task through the nfs4 error handling in
nfs4_lock_done() when we may have to reconcile our stateid with what the
server believes it to be.  For this case, the result is a retry of the
LOCK operation with the updated stateid.

Reported-by: Gonzalo Siero Humet <gsierohu@redhat.com>
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/nfs4proc.c