OSDN Git Service

drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Tue, 25 Jul 2023 04:39:42 +0000 (10:09 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 27 Jul 2023 18:59:29 +0000 (14:59 -0400)
commitf9acfafc3458653d306a45c71e052df50af1c81d
tree5b7c28f1799e353284fb61547c294c06538eb9a8
parentb0bd0a92b8158ea9c809d885e0f0c21518bdbd14
drm/amdgpu: Move externs to amdgpu.h file from amdgpu_drv.c

Fixes the following:

WARNING: externs should be avoided in .c files
+extern const struct attribute_group amdgpu_vram_mgr_attr_group;

WARNING: externs should be avoided in .c files
+extern const struct attribute_group amdgpu_gtt_mgr_attr_group;

WARNING: externs should be avoided in .c files
+extern const struct attribute_group amdgpu_flash_attr_group;

And other style fixes:

WARNING: Block comments should align the * on each line
WARNING: void function return statements are not generally useful
WARNING: braces {} are not necessary for single statement blocks

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu.h
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c