OSDN Git Service

(root) / android-x86 / frameworks-base.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9d9cf5b) | patch
Remove synchronization from getCurrentInputMethodSubtype()
authorGopal Krishna Shukla <gshukla@codeaurora.org>
Thu, 30 Jun 2016 06:04:21 +0000 (11:34 +0530)
committerYohei Yukawa <yukawa@google.com>
Fri, 16 Sep 2016 03:41:46 +0000 (03:41 +0000)
commitfa1886feea55785f413f5efcd86bccca92f26759
tree948877aebd186c4475e4313a09d52aab72db0113tree | snapshot
parent9d9cf5b383f26c209b781dbca0723f69ff6913bacommit | diff
Remove synchronization from getCurrentInputMethodSubtype()

getCurrentInputMethodSubtype() acquires InputManagerService.mMethodMap
within its body. There seems to be no reason for holding
InputMethodManager.mH to call getCurrentInputMethodSubtype(). Holding mH
can cause potential deadlock b/w two threads acquiring mH and mMethodMap
in different orders.

Bug: 31247871
Bug: 31273203
Bug: b.android.com/218423
Change-Id: I20cf2c20f49b1b02c0f7a18257b49d4bcc081b5d
core/java/android/view/inputmethod/InputMethodManager.java diff | blob | history
frameworks/base
About OSDN
Find Software
Develop Software
Help