OSDN Git Service

ASoC: simple-card: fix possible uninitialized single_cpu local variable
authorKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Wed, 7 Apr 2021 09:20:27 +0000 (11:20 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 7 Apr 2021 15:58:30 +0000 (16:58 +0100)
commitfa74c223b6fd78a5314b4c61b9abdbed3c2185b4
tree15db77f654b4bde81b7f519d737ff52b07e6ceb3
parentaf4b54127b2b8a69f0f50e54cf099f26b82c9244
ASoC: simple-card: fix possible uninitialized single_cpu local variable

The 'single_cpu' local variable is assigned by asoc_simple_parse_dai()
and later used in a asoc_simple_canonicalize_cpu() call, assuming the
entire function did not exit on errors.

However the first function returns 0 if passed device_node is NULL,
thus leaving the variable uninitialized and reporting success.

Addresses-Coverity: Uninitialized scalar variable
Fixes: 8f7f298a3337 ("ASoC: simple-card-utils: separate asoc_simple_card_parse_dai()")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Acked-by: Sameer Pujar <spujar@nvidia.com>
Link: https://lore.kernel.org/r/20210407092027.60769-1-krzysztof.kozlowski@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/generic/audio-graph-card.c
sound/soc/generic/simple-card.c