From 00a1f5bfa57bb4007a08435ba83b029dcebde5c0 Mon Sep 17 00:00:00 2001 From: Andreas Gampe Date: Fri, 27 Feb 2015 13:35:39 -0800 Subject: [PATCH] Revert "Revert "Re-enable one thread dumping the native stack of another."" This reverts commit edfdaf37d5520a3c3a858b6b3fba4f759c60dadc. Tests seem to succeed. Might be helpful to understand some deadlock/timeout situations. Bug: 15446488 Bug: 18713034 Change-Id: I5be225363f698556221576b5827d9501e26799f3 --- runtime/utils.cc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/runtime/utils.cc b/runtime/utils.cc index 6afc373f9..fd2f110cb 100644 --- a/runtime/utils.cc +++ b/runtime/utils.cc @@ -1264,14 +1264,6 @@ void DumpNativeStack(std::ostream& os, pid_t tid, const char* prefix, return; } -#if !defined(HAVE_ANDROID_OS) - if (GetTid() != tid) { - // TODO: dumping of other threads is disabled to avoid crashes during stress testing. - // b/15446488. - return; - } -#endif - std::unique_ptr backtrace(Backtrace::Create(BACKTRACE_CURRENT_PROCESS, tid)); if (!backtrace->Unwind(0, reinterpret_cast(ucontext_ptr))) { os << prefix << "(backtrace::Unwind failed for thread " << tid << ")\n"; -- 2.11.0