From 033a86f9bb6fd59ca71d4951b8e2e27cdc1b29d9 Mon Sep 17 00:00:00 2001 From: Diego Biurrun Date: Thu, 24 Jan 2013 17:01:32 +0100 Subject: [PATCH] x86: h264qpel: Move stray comment to the right spot and clarify it --- libavcodec/x86/dsputil_mmx.c | 2 -- libavcodec/x86/h264_qpel.c | 4 ++++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/x86/dsputil_mmx.c b/libavcodec/x86/dsputil_mmx.c index f9da04f6ea..f72500e4f0 100644 --- a/libavcodec/x86/dsputil_mmx.c +++ b/libavcodec/x86/dsputil_mmx.c @@ -2181,8 +2181,6 @@ static void dsputil_init_avx(DSPContext *c, AVCodecContext *avctx, int mm_flags) const int bit_depth = avctx->bits_per_raw_sample; if (bit_depth == 10) { - // AVX implies !cache64. - // TODO: Port cache(32|64) detection from x264. if (CONFIG_H264CHROMA) { c->put_h264_chroma_pixels_tab[0] = ff_put_h264_chroma_mc8_10_avx; c->avg_h264_chroma_pixels_tab[0] = ff_avg_h264_chroma_mc8_10_avx; diff --git a/libavcodec/x86/h264_qpel.c b/libavcodec/x86/h264_qpel.c index 9157223c84..64af8fe17c 100644 --- a/libavcodec/x86/h264_qpel.c +++ b/libavcodec/x86/h264_qpel.c @@ -611,6 +611,10 @@ void ff_h264qpel_init_x86(H264QpelContext *c, int bit_depth) } if (EXTERNAL_AVX(mm_flags)) { + /* AVX implies 64 byte cache lines without the need to avoid unaligned + * memory accesses that cross the boundary between two cache lines. + * TODO: Port X264_CPU_CACHELINE_32/64 detection from x264 to avoid + * having to treat SSE2 functions with such properties as AVX. */ if (bit_depth == 10) { H264_QPEL_FUNCS_10(1, 0, sse2); H264_QPEL_FUNCS_10(2, 0, sse2); -- 2.11.0