From 033d585be016d58c89e48892ed83e8b5ecaa7d09 Mon Sep 17 00:00:00 2001 From: msnyder Date: Tue, 1 Mar 2011 02:16:55 +0000 Subject: [PATCH] 2011-02-28 Michael Snyder * breakpoint.c (breakpoint_adjustment_warning): Make local char buffers a little bigger, to avoid possibility of an overflow. --- gdb/ChangeLog | 3 +++ gdb/breakpoint.c | 6 ++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 557f89f1ff..8fcf424b15 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,8 @@ 2011-02-28 Michael Snyder + * breakpoint.c (breakpoint_adjustment_warning): Make local char + buffers a little bigger, to avoid possibility of an overflow. + * coffread.c (coff_getfilename): Add check to avoid overflow. * objc-lang.c (selectors_info): Add a small safety margin to diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index bb9927c408..3fb8aab5fb 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -5504,8 +5504,10 @@ static void breakpoint_adjustment_warning (CORE_ADDR from_addr, CORE_ADDR to_addr, int bnum, int have_bnum) { - char astr1[40]; - char astr2[40]; + /* The longest string possibly returned by hex_string_custom + is 50 chars. These must be at least that big for safety. */ + char astr1[64]; + char astr2[64]; strcpy (astr1, hex_string_custom ((unsigned long) from_addr, 8)); strcpy (astr2, hex_string_custom ((unsigned long) to_addr, 8)); -- 2.11.0