From 04d1139533c612daebb56a2ab636d270149e54aa Mon Sep 17 00:00:00 2001 From: Ivailo Monev Date: Fri, 6 Nov 2020 16:47:39 +0200 Subject: [PATCH] avoid temporary in QFile::readLineData() Signed-off-by: Ivailo Monev --- src/core/io/qfile.cpp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/core/io/qfile.cpp b/src/core/io/qfile.cpp index 45f14d3df..5beeb8ab1 100644 --- a/src/core/io/qfile.cpp +++ b/src/core/io/qfile.cpp @@ -1311,16 +1311,12 @@ qint64 QFile::readLineData(char *data, qint64 maxlen) if (!d->ensureFlushed()) return -1; - qint64 read; if (d->fileEngine->supportsExtension(QAbstractFileEngine::FastReadLineExtension)) { - read = d->fileEngine->readLine(data, maxlen); - } else { - // Fall back to QIODevice's readLine implementation if the engine - // cannot do it faster. - read = QIODevice::readLineData(data, maxlen); + return d->fileEngine->readLine(data, maxlen); } - - return read; + // Fall back to QIODevice's readLine implementation if the engine + // cannot do it faster. + return QIODevice::readLineData(data, maxlen); } /*! -- 2.11.0