From 06c11f189bc32a6d577cd44e801b06bb6c66dae4 Mon Sep 17 00:00:00 2001 From: Raphael Date: Thu, 13 Oct 2011 17:28:14 -0700 Subject: [PATCH] SDK Manager: display source of packages in tooltip. Do not merge. (cherry picked from commit d0babf526623d775506553f28972d05064856960) Change-Id: Ib75d1af09f232d3f364b61500b812dd46bbf63ab --- .../repository/sdkman2/AddonSitesDialog.java | 1 + .../repository/sdkman2/AvdManagerWindowImpl1.java | 1 + .../internal/repository/sdkman2/PackagesPage.java | 21 ++++++++++++++++++++- .../repository/sdkman2/SdkUpdaterWindowImpl2.java | 1 + 4 files changed, 23 insertions(+), 1 deletion(-) diff --git a/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/AddonSitesDialog.java b/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/AddonSitesDialog.java index 0b866ff46..48cf9f75a 100755 --- a/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/AddonSitesDialog.java +++ b/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/AddonSitesDialog.java @@ -84,6 +84,7 @@ public class AddonSitesDialog extends SwtBaseDialog { /** * Create contents of the dialog. */ + @SuppressWarnings("unused") @Override protected void createContents() { Shell shell = getShell(); diff --git a/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/AvdManagerWindowImpl1.java b/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/AvdManagerWindowImpl1.java index a26e7efe7..301239c2f 100755 --- a/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/AvdManagerWindowImpl1.java +++ b/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/AvdManagerWindowImpl1.java @@ -190,6 +190,7 @@ public class AvdManagerWindowImpl1 { mAvdPage.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true, 2, 1)); } + @SuppressWarnings("unused") // MenuBarWrapper works using side effects private void createMenuBar() { if (mContext != AvdInvocationContext.STANDALONE) { diff --git a/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/PackagesPage.java b/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/PackagesPage.java index c7e43a1e0..4a8890b4c 100755 --- a/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/PackagesPage.java +++ b/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/PackagesPage.java @@ -75,6 +75,8 @@ import org.eclipse.swt.widgets.Tree; import org.eclipse.swt.widgets.TreeColumn; import java.io.File; +import java.net.MalformedURLException; +import java.net.URL; import java.util.ArrayList; import java.util.HashMap; import java.util.List; @@ -176,6 +178,7 @@ public class PackagesPage extends UpdaterPage } } + @SuppressWarnings("unused") private void createContents(Composite parent) { GridLayoutBuilder.create(parent).noMargins().columns(2); @@ -1513,7 +1516,23 @@ public class PackagesPage extends UpdaterPage element = ((PkgItem) element).getMainPackage(); } if (element instanceof IDescription) { - return ((IDescription) element).getLongDescription(); + String s = ((IDescription) element).getLongDescription(); + if (element instanceof Package) { + SdkSource src = ((Package) element).getParentSource(); + if (src != null) { + try { + URL url = new URL(src.getUrl()); + String host = url.getHost(); + if (((Package) element).isLocal()) { + s += String.format("\nInstalled from %1$s", host); + } else { + s += String.format("\nProvided by %1$s", host); + } + } catch (MalformedURLException ignore) { + } + } + } + return s; } return super.getToolTipText(element); } diff --git a/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/SdkUpdaterWindowImpl2.java b/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/SdkUpdaterWindowImpl2.java index d7d8dc6c0..6740dbb5f 100755 --- a/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/SdkUpdaterWindowImpl2.java +++ b/sdkmanager/libs/sdkuilib/src/com/android/sdkuilib/internal/repository/sdkman2/SdkUpdaterWindowImpl2.java @@ -236,6 +236,7 @@ public class SdkUpdaterWindowImpl2 implements ISdkUpdaterWindow { }); } + @SuppressWarnings("unused") // MenuItem works using side effects private void createMenuBar() { Menu menuBar = new Menu(mShell, SWT.BAR); -- 2.11.0