From 097b4a3b28ecab81b356b86f04a939d24b94ae77 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Wed, 19 Sep 2012 13:27:55 -0700 Subject: [PATCH] i965: Allow fast depth clears if scissoring doesn't do anything. A game we're working with leaves scissoring enabled, but frequently sets the scissor rectangle to the size of the whole screen. In that case, scissoring has no effect, so it's safe to go ahead with a fast clear. Chad believe this should help with Oliver McFadden's "Dante" as well. v2/Chad: Use the drawbuffer dimensions rather than the miptree slice dimensions. The miptree slice may be slightly larger due to alignment restrictions. Signed-off-by: Kenneth Graunke Signed-off-by: Chad Versace Reviewed-and-tested-by: Oliver McFadden --- src/mesa/drivers/dri/i965/brw_clear.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_clear.c b/src/mesa/drivers/dri/i965/brw_clear.c index ce40e52d461..53d8e5400ef 100644 --- a/src/mesa/drivers/dri/i965/brw_clear.c +++ b/src/mesa/drivers/dri/i965/brw_clear.c @@ -77,6 +77,18 @@ debug_mask(const char *name, GLbitfield mask) } /** + * Returns true if the scissor is a noop (cuts out nothing). + */ +static bool +noop_scissor(struct gl_context *ctx, struct gl_framebuffer *fb) +{ + return ctx->Scissor.X <= 0 && + ctx->Scissor.Y <= 0 && + ctx->Scissor.Width >= fb->Width && + ctx->Scissor.Height >= fb->Height; +} + +/** * Implements fast depth clears on gen6+. * * Fast clears basically work by setting a flag in each of the subspans @@ -107,7 +119,7 @@ brw_fast_clear_depth(struct gl_context *ctx) * a previous clear had happened at a different clear value and resolve it * first. */ - if (ctx->Scissor.Enabled) { + if (ctx->Scissor.Enabled && !noop_scissor(ctx, fb)) { perf_debug("Failed to fast clear depth due to scissor being enabled. " "Possible 5%% performance win if avoided.\n"); return false; -- 2.11.0