From 0b25167d1cdd42f56c18f8d666a412bbefc819ac Mon Sep 17 00:00:00 2001 From: Wolfram Sang Date: Thu, 13 Jun 2019 12:54:19 -0300 Subject: [PATCH] media: mn88473: don't check retval after our own assignemt No need to check a retval after we assigned a constant to it. Signed-off-by: Wolfram Sang Reviewed-by: Kieran Bingham Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/mn88473.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb-frontends/mn88473.c b/drivers/media/dvb-frontends/mn88473.c index 71cedce6c7d0..4838969ef735 100644 --- a/drivers/media/dvb-frontends/mn88473.c +++ b/drivers/media/dvb-frontends/mn88473.c @@ -661,8 +661,7 @@ static int mn88473_probe(struct i2c_client *client, if (IS_ERR(dev->client[1])) { ret = PTR_ERR(dev->client[1]); dev_err(&client->dev, "I2C registration failed\n"); - if (ret) - goto err_regmap_0_regmap_exit; + goto err_regmap_0_regmap_exit; } dev->regmap[1] = regmap_init_i2c(dev->client[1], ®map_config); if (IS_ERR(dev->regmap[1])) { @@ -675,8 +674,7 @@ static int mn88473_probe(struct i2c_client *client, if (IS_ERR(dev->client[2])) { ret = PTR_ERR(dev->client[2]); dev_err(&client->dev, "2nd I2C registration failed\n"); - if (ret) - goto err_regmap_1_regmap_exit; + goto err_regmap_1_regmap_exit; } dev->regmap[2] = regmap_init_i2c(dev->client[2], ®map_config); if (IS_ERR(dev->regmap[2])) { -- 2.11.0