From 0d11781df02b2d7526d39ab045d417f98aaa5817 Mon Sep 17 00:00:00 2001 From: Mike Lockwood Date: Thu, 28 May 2009 10:19:17 -0400 Subject: [PATCH] InetAddress: Stop logging DNS lookups to logcat. Logging all DNS lookups system wide raises privacy concerns to me and might make people less likely to include logs in their bug reports. Signed-off-by: Mike Lockwood --- libcore/luni/src/main/native/java_net_InetAddress.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libcore/luni/src/main/native/java_net_InetAddress.cpp b/libcore/luni/src/main/native/java_net_InetAddress.cpp index 0eb2753c9..c0666d5fb 100644 --- a/libcore/luni/src/main/native/java_net_InetAddress.cpp +++ b/libcore/luni/src/main/native/java_net_InetAddress.cpp @@ -16,6 +16,8 @@ #define LOG_TAG "InetAddress" +#define LOG_DNS 0 + #include "JNIHelp.h" #include "utils/Log.h" #include "jni.h" @@ -59,6 +61,7 @@ static void throwNullPointerException(JNIEnv* env) } } +#if LOG_DNS static void logIpString(struct addrinfo* ai, const char* name) { char ipString[INET6_ADDRSTRLEN]; @@ -71,6 +74,11 @@ static void logIpString(struct addrinfo* ai, const char* name) LOGE("%s: getnameinfo: %s", name, gai_strerror(result)); } } +#else +static inline void logIpString(struct addrinfo* ai, const char* name) +{ +} +#endif static jobjectArray getAllByNameUsingAdb(JNIEnv* env, const char* name) { -- 2.11.0