From 11b3d92d7c8a61290e608d54ad2982a653f6ee5b Mon Sep 17 00:00:00 2001 From: Alex Light Date: Wed, 8 Feb 2017 10:45:12 -0800 Subject: [PATCH] Ensure that both stderr and stdout are captured We were not capturing the stdout FD for the run-test process. This was leading to blank lines being printed during the running of some tests. Test: ./test/testrunner/testrunner.py --host -j40 Change-Id: I1fb50fb6ae2af9c439f126c9fe47a3e24ad84e10 --- test/testrunner/testrunner.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/testrunner/testrunner.py b/test/testrunner/testrunner.py index fd3ebd1d4..00cb497e2 100755 --- a/test/testrunner/testrunner.py +++ b/test/testrunner/testrunner.py @@ -452,8 +452,8 @@ def run_test(command, test, test_variant, test_name): test_skipped = True else: test_skipped = False - proc = subprocess.Popen(command.split(), stderr=subprocess.PIPE) - script_output = proc.stderr.read().strip() + proc = subprocess.Popen(command.split(), stderr=subprocess.STDOUT, stdout=subprocess.PIPE) + script_output = proc.stdout.read().strip() test_passed = not proc.wait() # If verbose is set to True, every test information is printed on a new line. -- 2.11.0