From 11e03e7c2d0c163e54b911ad1e665616dc0bcc8c Mon Sep 17 00:00:00 2001 From: Jim Grosbach Date: Mon, 22 Aug 2011 18:50:36 +0000 Subject: [PATCH] Tighten up ARM reglist validation a bit. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@138258 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/ARM/AsmParser/ARMAsmParser.cpp | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/lib/Target/ARM/AsmParser/ARMAsmParser.cpp b/lib/Target/ARM/AsmParser/ARMAsmParser.cpp index 3e768f25317..31300aea569 100644 --- a/lib/Target/ARM/AsmParser/ARMAsmParser.cpp +++ b/lib/Target/ARM/AsmParser/ARMAsmParser.cpp @@ -24,6 +24,7 @@ #include "llvm/Target/TargetRegistry.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Support/raw_ostream.h" +#include "llvm/ADT/BitVector.h" #include "llvm/ADT/OwningPtr.h" #include "llvm/ADT/STLExtras.h" #include "llvm/ADT/SmallVector.h" @@ -1661,17 +1662,11 @@ parseRegisterList(SmallVectorImpl &Operands) { Parser.Lex(); // Eat right curly brace token. // Verify the register list. - SmallVectorImpl >::const_iterator - RI = Registers.begin(), RE = Registers.end(); - - unsigned HighRegNum = getARMRegisterNumbering(RI->first); bool EmittedWarning = false; - - DenseMap RegMap; - RegMap[HighRegNum] = true; - - for (++RI; RI != RE; ++RI) { - const std::pair &RegInfo = *RI; + unsigned HighRegNum = 0; + BitVector RegMap(32); + for (unsigned i = 0, e = Registers.size(); i != e; ++i) { + const std::pair &RegInfo = Registers[i]; unsigned Reg = getARMRegisterNumbering(RegInfo.first); if (RegMap[Reg]) { @@ -1683,7 +1678,7 @@ parseRegisterList(SmallVectorImpl &Operands) { Warning(RegInfo.second, "register not in ascending order in register list"); - RegMap[Reg] = true; + RegMap.set(Reg); HighRegNum = std::max(Reg, HighRegNum); } -- 2.11.0