From 12a7f71a8ea5218e004f7226a7cb0d1005952c85 Mon Sep 17 00:00:00 2001 From: Douglas Anderson Date: Wed, 29 Sep 2021 15:38:14 -0700 Subject: [PATCH] arm64: dts: qcom: pmk8350: Make RTC disabled by default; enable on sc7280-idp The RTC on the pmk8350 is not useful on all boards. Some boards may not provide backup power to the PMIC but might have another RTC on the board that does have backup power. In this case it's better to not use the RTC on the PMIC. At the moment, the only boards that includes this PMIC are sc7280-idp and sc7280-idp2. On sc7280-idp I'm not aware of any other RTCs, but sc7280-idp2 has a Chrome OS EC on it and this is intended to provide the RTC for the AP. Let's do what we normally do for hardware that's not used by all boards and set it to a default status of "disabled" and then enable it on the boards that need it. NOTE: for sc7280-idp it's _possible_ we might also want to add `allow-set-time;`. That could be the subject of a future patch if it is indeed true. Signed-off-by: Douglas Anderson Reviewed-by: Satya Priya Reviewed-by: Stephen Boyd Reviewed-by: Matthias Kaehlcke [bjorn: Enable the RTC on the MTP as well] Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20210929153553.1.Ib44c2ac967833d7a3f51452d44d15b7b8d23c1f0@changeid --- arch/arm64/boot/dts/qcom/pmk8350.dtsi | 1 + arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++ arch/arm64/boot/dts/qcom/sm8350-mtp.dts | 4 ++++ 3 files changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi index 04fc2632a0b2..769f9726806f 100644 --- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi +++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi @@ -59,6 +59,7 @@ reg = <0x6100>, <0x6200>; reg-names = "rtc", "alarm"; interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>; + status = "disabled"; }; pmk8350_gpios: gpio@b000 { diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts index 64fc22aff33d..e11412bae738 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts @@ -61,6 +61,10 @@ modem-init; }; +&pmk8350_rtc { + status = "okay"; +}; + &pmk8350_vadc { pmr735a_die_temp { reg = ; diff --git a/arch/arm64/boot/dts/qcom/sm8350-mtp.dts b/arch/arm64/boot/dts/qcom/sm8350-mtp.dts index bd95009c1875..06f1c14dbfde 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8350-mtp.dts @@ -286,6 +286,10 @@ firmware-name = "qcom/sm8350/modem.mbn"; }; +&pmk8350_rtc { + status = "okay"; +}; + &qupv3_id_0 { status = "okay"; }; -- 2.11.0