From 14a561b2c1a0d30c36751ea756c773d70c9c4d76 Mon Sep 17 00:00:00 2001 From: Russell Brenner Date: Mon, 25 Jul 2011 16:25:38 -0700 Subject: [PATCH] Fix for Devanagari diacritical marks It appears that offsetX and advance were at odds with each other. Eliminating offsetX causes the diacritical marks to be positioned correctly. Bug: 4309954 Change-Id: I51fbdd4523ba7de1a2d981b971fdd4f1d42b979c --- Source/WebCore/platform/graphics/android/FontAndroid.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Source/WebCore/platform/graphics/android/FontAndroid.cpp b/Source/WebCore/platform/graphics/android/FontAndroid.cpp index af2edc760..b56e37cd1 100644 --- a/Source/WebCore/platform/graphics/android/FontAndroid.cpp +++ b/Source/WebCore/platform/graphics/android/FontAndroid.cpp @@ -717,8 +717,7 @@ void TextRunWalker::setGlyphXPositions(bool isRTL) int i = isRTL ? m_item.num_glyphs - iter - 1 : iter; m_glyphs16[i] = m_item.glyphs[i]; - int offsetX = truncateFixedPointToInteger(m_item.offsets[i].x); - m_xPositions[i] = SkIntToScalar(m_offsetX + position + offsetX); + m_xPositions[i] = SkIntToScalar(m_offsetX + position); int advance = truncateFixedPointToInteger(m_item.advances[i]); // The first half of the conjunction works around the case where -- 2.11.0